Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optimize expose #84

Merged
merged 6 commits into from
May 4, 2023
Merged

fix: optimize expose #84

merged 6 commits into from
May 4, 2023

Conversation

productdevbook
Copy link
Member

@productdevbook productdevbook commented May 4, 2023

Thank you @johnsoncodehk

close #52
close #69

<script setup lang="ts">
import type { ComponentPublicInstance } from 'vue'
import { onMounted, ref } from 'vue'
import { OkuLabel } from '@oku-ui/label'

const labelRef = ref<Omit<InstanceType<typeof OkuLabel>, keyof ComponentPublicInstance>>()
onMounted(() => {
  console.log(labelRef.value?.innerRef)
})
</script>

<template>
  <div>
    <div class="flex flex-col">
      <OkuLabel ref="labelRef" class="text-black text-2xl" for="firstName">
        Label
      </OkuLabel>
      <input id="firstName" class="mt-4" type="text" defaultValue="Pedro Duarte">
    </div>
  </div>
</template>

@productdevbook productdevbook self-assigned this May 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

Coverage Summary

Status Category Percentage Covered / Total
🔵 Lines 63.3% 157 / 248
🔵 Statements 63.3% 157 / 248
🔵 Functions 50% 5 / 10
🔵 Branches 69.23% 9 / 13
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
packages/core/primitive/src/index.ts 100% 100% 100% 100%
packages/core/primitive/src/primitive.ts 100% 62.5% 100% 100%
packages/core/provide/src/createProvide.ts 33.57% 75% 33.33% 33.57% 23-30, 51-107, 109-134
packages/core/provide/src/index.ts 100% 100% 0% 100%

@productdevbook productdevbook merged commit 0d3aabf into main May 4, 2023
@productdevbook productdevbook deleted the optimize-expose branch May 4, 2023 14:15
This was referenced May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type 'string' is not assignable to type 'Ref<any> with .vue defineComponent props TS error
1 participant